summaryrefslogtreecommitdiffstats
path: root/core
diff options
context:
space:
mode:
Diffstat (limited to 'core')
-rw-r--r--core/views/caves.py11
-rw-r--r--core/views/other.py18
-rw-r--r--core/views/uploads.py3
-rw-r--r--core/views/wallets_edit.py6
4 files changed, 21 insertions, 17 deletions
diff --git a/core/views/caves.py b/core/views/caves.py
index c970f52..fa5e7ef 100644
--- a/core/views/caves.py
+++ b/core/views/caves.py
@@ -21,8 +21,15 @@ from .auth import login_required_if_public
Manages the use of cavern to parse survex files to produce 3d and pos files
"""
-todo = """- Fix rendercave() so that CaveView works
-- in getCaves() search GCavelookup first, which should raise a MultpleObjectsReturned exception if no duplicates
+todo = """
+- Fix rendercave() so that CaveView works
+
+- in getCaves() search GCavelookup first, which should raise a MultpleObjectsReturned
+ exception if no duplicates
+
+- Learn to use Django .select_related() and .prefetch_related() to speed things up
+ especially on the big report pages
+ https://zerotobyte.com/how-to-use-django-select-related-and-prefetch-related/
"""
diff --git a/core/views/other.py b/core/views/other.py
index df347ea..8d40079 100644
--- a/core/views/other.py
+++ b/core/views/other.py
@@ -28,12 +28,8 @@ progress and task list (deprecated as we do not have individual user login).
"""
todo = """
-
-- Use logbookdownloader to convert all older logbooks into the 2005-variant of HTML then we can
- get rid of the parsers for older formats.
- When we have done all the old logbooks, delete this function and the two templates.
-
- OR invent a new format, e.g. using <article> and <section>?, which is better!
+- [Low priority] Fix Login page so that it produces the frontpage or
+ redirects to the page which produced the login prompt requirement.
"""
@@ -175,18 +171,16 @@ def controlpanel(request):
def exportlogbook(request, year=None, extension=None):
"""Constructs, from the database, a complete HTML formatted logbook
- for the current year. Formats available are HTML2005 (others old & broken or not written yet)
-
- There are no images stored in the database, so this is only a tool for a first pass, to be followed by
- hand-editing. However links to images work in the HTML text of a logbook entry
+ for the current year. Formats available are HTML2005. Other formats
+ have been retired.
- NEED TO ADD IN THE MATERIAL WHICH IS NOT IN ANY LBE ! e.g. front matter.
+ There are no images stored in the database. However links to images work in the HTML text of a logbook entry.
This function is the recipient of the POST action os the export form in the control panel
"""
def lbeKey(lbe):
- """This function goes into a lexicogrpahic sort function"""
+ """This function goes into a lexicographic sort function"""
return str(lbe.date)
if not request.method == "POST":
diff --git a/core/views/uploads.py b/core/views/uploads.py
index 21a6844..d6aaf8d 100644
--- a/core/views/uploads.py
+++ b/core/views/uploads.py
@@ -20,7 +20,7 @@ from .auth import login_required_if_public
"""
todo = """
-- Register uploaded filenames in the Django db without needing to wait for a reset & bulk file import
+- Register freshly uploaded filenames in the Django db without needing to wait for a reset & bulk file import
- Need to validate uploaded file as being a valid file type, not a dubious script or hack
@@ -33,7 +33,6 @@ todo = """
https://stackoverflow.com/questions/889333/how-to-check-if-a-file-is-a-valid-image-file
- Enable folder creation in dwguploads or as a separate form
-
"""
class FilesForm(forms.Form): # not a model-form, just a form-form
diff --git a/core/views/wallets_edit.py b/core/views/wallets_edit.py
index c601667..6083dab 100644
--- a/core/views/wallets_edit.py
+++ b/core/views/wallets_edit.py
@@ -31,9 +31,13 @@ from troggle.parsers.scans import contentsjson
"""
todo = """
+- Nasty bug in navingating to 'previous wallet' when we have a 2-year gap in expos
+ The xxxx#00 wallet is not getting edited correctly. Something is off by one somewhere..
+
- Register uploaded filenames in the Django db without needing to wait for a reset & bulk file import
-- Refactor walletedit() as it contains all the wallets 'complaints' code from the pre-2022 script wallets.py
+- Refactor walletedit() as it contains all the wallets 'complaints' code from the pre-2022
+ script 'wallets.py'
- Need to validate uploaded file as being a valid image file, not a dubious script or hack
"""