diff options
Diffstat (limited to 'core/models/troggle.py')
-rw-r--r-- | core/models/troggle.py | 14 |
1 files changed, 3 insertions, 11 deletions
diff --git a/core/models/troggle.py b/core/models/troggle.py index 89e6e00..237247f 100644 --- a/core/models/troggle.py +++ b/core/models/troggle.py @@ -154,8 +154,8 @@ class PersonExpedition(TroggleModel): is deleted too """ - expedition = models.ForeignKey(Expedition, on_delete=models.CASCADE) - person = models.ForeignKey(Person, on_delete=models.CASCADE) + expedition = models.ForeignKey(Expedition, on_delete=models.CASCADE, db_index=True) + person = models.ForeignKey(Person, on_delete=models.CASCADE, db_index=True) slugfield = models.SlugField(max_length=50, blank=True, null=True) # 2022 to be used in future # is_guest = models.BooleanField(default=False) # This is per-Person, not per-PersonExpedition @@ -170,6 +170,7 @@ class PersonExpedition(TroggleModel): def get_absolute_url(self): # we do not use URL_ROOT any more. + # This is crackers, the whole point of get_absolute_url is to use the automatic reverse resolution, see below return(f"/personexpedition/{self.person.slug}/{self.expedition.year}") # why does this hang the system ? return reverse( @@ -179,15 +180,6 @@ class PersonExpedition(TroggleModel): "year": self.expedition.year, }, ) - # old style, no longer used - return reverse( - "personexpedition", - kwargs={ - "first_name": self.person.first_name, - "last_name": self.person.last_name, - "year": self.expedition.year, - }, - ) def surveyedleglength(self): """Survey length for this person on all survex trips on this expedition""" |