diff options
author | Philip Sargent <philip.sargent@gmail.com> | 2023-11-03 16:54:29 +0200 |
---|---|---|
committer | Philip Sargent <philip.sargent@gmail.com> | 2023-11-03 16:54:29 +0200 |
commit | fc60bde3ec6248bc4a53b84e89f105229ca6a5c3 (patch) | |
tree | a581e9263c7e46c50dbc91d162b24d436ea9c685 /core/models/caves.py | |
parent | c7cb8ece2eb8f7c711f5fce4c2f53b319011955d (diff) | |
download | troggle-fc60bde3ec6248bc4a53b84e89f105229ca6a5c3.tar.gz troggle-fc60bde3ec6248bc4a53b84e89f105229ca6a5c3.tar.bz2 troggle-fc60bde3ec6248bc4a53b84e89f105229ca6a5c3.zip |
comments and tidy
Diffstat (limited to 'core/models/caves.py')
-rw-r--r-- | core/models/caves.py | 16 |
1 files changed, 9 insertions, 7 deletions
diff --git a/core/models/caves.py b/core/models/caves.py index 60ff8d1..ab8414b 100644 --- a/core/models/caves.py +++ b/core/models/caves.py @@ -32,7 +32,7 @@ todo = """ - Can we rewrite things to eliminate the CaveSlug and objects? Surely foreign keys work fine ?! -- Why do we have CaveAndEntrance objects ? +- Why do we have CaveAndEntrance objects ? These do not need to be explcit for a many:many relationship these days - move the aliases list from the code and put into an editable file @@ -112,12 +112,12 @@ class Cave(TroggleModel): def get_absolute_url(self): # we do not use URL_ROOT any more. - if self.kataster_number: - pass - elif self.unofficial_number: - pass - else: - self.official_name.lower() + # if self.kataster_number: + # pass + # elif self.unofficial_number: + # pass + # else: + # self.official_name.lower() return self.url # not good Django style? NEEDS actual URL def url_parent(self): @@ -199,6 +199,8 @@ class Cave(TroggleModel): return res def writeDataFile(self): + """Seems to be a duplicate of file_output() ?! + REFACTOR""" filepath = os.path.join(settings.CAVEDESCRIPTIONS, self.filename) t = loader.get_template("dataformat/cave.xml") |