From 0a3037f077dabc39c386a6aea5668b661e64ea7b Mon Sep 17 00:00:00 2001 From: Philip Sargent Date: Thu, 30 Dec 2021 19:46:44 +0000 Subject: let exceptions bubble up --- core/views/caves.py | 18 ++++++++++-------- 1 file changed, 10 insertions(+), 8 deletions(-) (limited to 'core/views/caves.py') diff --git a/core/views/caves.py b/core/views/caves.py index 8824425..c8ee7e8 100644 --- a/core/views/caves.py +++ b/core/views/caves.py @@ -359,14 +359,16 @@ def edit_cave(request, slug=None): for ceinst in ceinsts: ceinst.cave = cave ceinst.save() - try: - cave.writeDataFile() - except PermissionError: - message = f'CANNOT save this file.\nPERMISSIONS incorrectly set on server for this file {cave.filename}. Ask a nerd to fix this.' - return render(request,'errors/generic.html', {'message': message}) - except: - message = f'CANNOT git on server for this file {cave.filename}. Edits not saved.\nAsk a nerd to fix this.' - return render(request,'errors/generic.html', {'message': message}) + cave.writeDataFile() + # try: + # cave.writeDataFile() + # except PermissionError: + # message = f'CANNOT save this file.\nPERMISSIONS incorrectly set on server for this file {cave.filename}. Ask a nerd to fix this.' + # return render(request,'errors/generic.html', {'message': message}) + # leave other exeptions unhandled so that they bubble up to userinterface + # except: + # message = f'CANNOT git on server for this file {cave.filename}. Edits not saved.\nAsk a nerd to fix this.' + # return render(request,'errors/generic.html', {'message': message}) return HttpResponseRedirect("/" + cave.url) else: -- cgit v1.2.3