From daf58e9e45b5c2d94cbdcd00d9883cfa6b01c6dd Mon Sep 17 00:00:00 2001 From: Philip Sargent Date: Tue, 13 Apr 2021 22:27:01 +0100 Subject: replace assert() with message logging --- core/models/caves.py | 1 - core/models/troggle.py | 3 +-- 2 files changed, 1 insertion(+), 3 deletions(-) (limited to 'core/models') diff --git a/core/models/caves.py b/core/models/caves.py index be44e8f..edaae9a 100644 --- a/core/models/caves.py +++ b/core/models/caves.py @@ -1,7 +1,6 @@ import string import os import datetime -import logging import re import json from subprocess import call diff --git a/core/models/troggle.py b/core/models/troggle.py index cf32893..f1f10be 100644 --- a/core/models/troggle.py +++ b/core/models/troggle.py @@ -1,7 +1,6 @@ import string import os import datetime -import logging import re import resource from subprocess import call @@ -51,7 +50,7 @@ class DataIssue(TroggleModel): This is a use of the NOTIFICATION pattern: https://martinfowler.com/eaaDev/Notification.html - And we need to use it to replace all assertions in the code too: + We have replaced all assertions in the code with messages and local fix-ups or skips: https://martinfowler.com/articles/replaceThrowWithNotification.html """ date = models.DateTimeField(auto_now_add=True, blank=True) -- cgit v1.2.3