diff options
| -rw-r--r-- | core/views/caves.py | 2 | ||||
| -rw-r--r-- | core/views/logbook_edit.py | 7 | ||||
| -rw-r--r-- | core/views/wallets_edit.py | 1 |
3 files changed, 7 insertions, 3 deletions
diff --git a/core/views/caves.py b/core/views/caves.py index 84f0569..d5e0fe3 100644 --- a/core/views/caves.py +++ b/core/views/caves.py @@ -101,7 +101,7 @@ def get_cave_from_slug(caveslug): return None def caveslugfwd(request, slug): - """This is ass backwards. It would be better style to have the slug-identified request be the master, and have + """This is arse-backwards. It would be better style to have the slug-identified request be the master, and have other paths redirect to it, rather than what we have here. Pending a change where we remove cave.url as a field and have an explicit fixed convention instead. """ diff --git a/core/views/logbook_edit.py b/core/views/logbook_edit.py index 3819794..56b040f 100644 --- a/core/views/logbook_edit.py +++ b/core/views/logbook_edit.py @@ -33,7 +33,12 @@ Note that there are other file upload forms in views/wallet_edit.py views/upload and that core/forms.py contains Django class-based forms for caves and entrances.
"""
-todo = """ - refactor git to use utils.py functions
+todo = """ - It's all still a bit messy.
+
+ - When this is used to create a totally new form, we could with some integration between the Logbook Entry author
+and the git "--author" field which is used (only) for the version control attribution.
+
+ - Track down how James Waite crashes this every time he touches it. (Or did in 2024)
"""
def create_new_lbe_slug(date):
diff --git a/core/views/wallets_edit.py b/core/views/wallets_edit.py index e36e7e4..3bd4b43 100644 --- a/core/views/wallets_edit.py +++ b/core/views/wallets_edit.py @@ -25,7 +25,6 @@ from troggle.core.utils import ( add_commit, current_expo, get_cookie, - git_add, git_commit, git_string, sanitize_name, |