diff options
author | Martin <devnull@localhost> | 2012-08-14 22:51:15 +0200 |
---|---|---|
committer | Martin <devnull@localhost> | 2012-08-14 22:51:15 +0200 |
commit | 1a0e5776069b654796fc9fb9910db491b67fe152 (patch) | |
tree | 8bafae7583b5375de5589c0a1ecbd46414401fd3 /core | |
parent | ecd5bbcb1dbb00cc0d39cdf80151f41c07c6c8b2 (diff) | |
download | troggle-1a0e5776069b654796fc9fb9910db491b67fe152.tar.gz troggle-1a0e5776069b654796fc9fb9910db491b67fe152.tar.bz2 troggle-1a0e5776069b654796fc9fb9910db491b67fe152.zip |
Bug fixing of cave and entrance forms removal of slugs
Diffstat (limited to 'core')
-rw-r--r-- | core/forms.py | 17 | ||||
-rw-r--r-- | core/models.py | 6 | ||||
-rw-r--r-- | core/views_caves.py | 48 |
3 files changed, 54 insertions, 17 deletions
diff --git a/core/forms.py b/core/forms.py index da16d79..75814ee 100644 --- a/core/forms.py +++ b/core/forms.py @@ -16,12 +16,21 @@ class CaveForm(ModelForm): underground_centre_line = forms.CharField(required = False, widget=forms.Textarea()) notes = forms.CharField(required = False, widget=forms.Textarea()) references = forms.CharField(required = False, widget=forms.Textarea()) - slug = forms.CharField(required = True) url = forms.CharField(required = True) class Meta: model = Cave exclude = ("filename",) + + def clean(self): + if self.cleaned_data.get("kataster_number") == "" and self.cleaned_data.get("unofficial_number") == "": + self._errors["unofficial_number"] = self.error_class(["Either the kataster or unoffical number is required."]) + if self.cleaned_data.get("kataster_number") != "" and self.cleaned_data.get("official_name") == "": + self._errors["official_name"] = self.error_class(["This field is required when there is a kataster number."]) + if self.cleaned_data.get("area") == []: + self._errors["area"] = self.error_class(["This field is required."]) + return self.cleaned_data + class VersionControlCommentForm(forms.Form): description_of_change = forms.CharField(required = True, widget=forms.Textarea()) @@ -41,7 +50,6 @@ class EntranceForm(ModelForm): northing = forms.CharField(required=False) # Trying to change this to a singl;e line entry easting = forms.CharField(required=False) # Trying to change this to a singl;e line entry alt = forms.CharField(required=False) # Trying to change this to a singl;e line entry - slug = forms.CharField() class Meta: model = Entrance exclude = ("cached_primary_slug", "filename",) @@ -50,6 +58,11 @@ class EntranceForm(ModelForm): CaveAndEntranceFormSet = modelformset_factory(CaveAndEntrance, exclude=('cave')) +class EntranceLetterForm(ModelForm): + class Meta: + model = CaveAndEntrance + exclude = ('cave', 'entrance') + #class PersonForm(ModelForm): # class Meta: # model = Person diff --git a/core/models.py b/core/models.py index 1c86dd5..180ac9d 100644 --- a/core/models.py +++ b/core/models.py @@ -571,13 +571,13 @@ class Entrance(TroggleModel): def find_location(self): if self.tag_station: s = SurvexStation.objects.lookup(self.tag_station) - return "%sE %sN %sAlt" % (s.x, s.y, s.z) + return "%0.0fE %0.0fN %0.0fAlt" % (s.x, s.y, s.z) if self.exact_station: s = SurvexStation.objects.lookup(self.exact_station) - return "%sE %sN %sAlt" % (s.x, s.y, s.z) + return "%0.0fE %0.0fN %0.0fAlt" % (s.x, s.y, s.z) if self.other_station: s = SurvexStation.objects.lookup(self.other_station) - return "%sE %sN %sAlt %s" % (s.x, s.y, s.z, self.other_description) + return "%0.0fE %0.0fN %0.0fAlt %s" % (s.x, s.y, s.z, self.other_description) if self.bearings: return self.bearings diff --git a/core/views_caves.py b/core/views_caves.py index 2590cf1..16dbaac 100644 --- a/core/views_caves.py +++ b/core/views_caves.py @@ -1,5 +1,5 @@ from troggle.core.models import CaveSlug, Cave, CaveAndEntrance, Survey, Expedition, QM, CaveDescription, EntranceSlug, Entrance, Area -from troggle.core.forms import CaveForm, CaveAndEntranceFormSet, VersionControlCommentForm, EntranceForm +from troggle.core.forms import CaveForm, CaveAndEntranceFormSet, VersionControlCommentForm, EntranceForm, EntranceLetterForm import troggle.core.models as models import troggle.settings as settings from troggle.helper import login_required_if_public @@ -104,11 +104,21 @@ def edit_cave(request, slug=None): versionControlForm = VersionControlCommentForm(request.POST) if form.is_valid() and ceFormSet.is_valid() and versionControlForm.is_valid(): cave = form.save(commit = False) - cave.filename = form.cleaned_data["slug"] + ".html" + if slug is None: + for a in form.cleaned_data["area"]: + if a.kat_area(): + myArea = a.kat_area() + if form.cleaned_data["kataster_number"]: + myslug = "%s-%s" % (myArea, form.cleaned_data["kataster_number"]) + else: + myslug = "%s-%s" % (myArea, form.cleaned_data["unofficial_number"]) + else: + myslug = slug + cave.filename = myslug + ".html" cave.save() form.save_m2m() if slug is None: - cs = CaveSlug(cave = cave, slug = form.cleaned_data["slug"], primary = True) + cs = CaveSlug(cave = cave, slug = myslug, primary = True) cs.save() ceinsts = ceFormSet.save(commit=False) for ceinst in ceinsts: @@ -129,7 +139,8 @@ def edit_cave(request, slug=None): }) @login_required_if_public -def editEntrance(request, slug=None): +def editEntrance(request, caveslug, slug=None): + cave = Cave.objects.get(caveslug__slug = caveslug) if slug is not None: entrance = Entrance.objects.get(entranceslug__slug = slug) else: @@ -137,25 +148,38 @@ def editEntrance(request, slug=None): if request.POST: form = EntranceForm(request.POST, instance = entrance) versionControlForm = VersionControlCommentForm(request.POST) - if form.is_valid() and versionControlForm.is_valid(): + if slug is None: + entletter = EntranceLetterForm(request.POST) + else: + entletter = None + if form.is_valid() and versionControlForm.is_valid() and (slug is not None or entletter.is_valid()): entrance = form.save(commit = False) - entrance.filename = form.cleaned_data["slug"] + ".html" if slug is None: - entrance.cached_primary_slug = form.cleaned_data["slug"] + slugname = cave.slug() + entletter.cleaned_data["entrance_letter"] + entrance.cached_primary_slug = slugname + entrance.filename = slugname + ".html" entrance.save() if slug is None: - es = EntranceSlug(entrance = entrance, slug = form.cleaned_data["slug"], primary = True) - es.save() + es = EntranceSlug(entrance = entrance, slug = slugname, primary = True) + es.save() + el = entletter.save(commit = False) + el.cave = cave + el.entrance = entrance + el.save() entrance.writeDataFile() - return HttpResponseRedirect("/" + entrance.url) + return HttpResponseRedirect("/" + cave.url) else: form = EntranceForm(instance = entrance) versionControlForm = VersionControlCommentForm() - + if slug is None: + entletter = EntranceLetterForm(request.POST) + else: + entletter = None return render_with_context(request, 'editentrance.html', {'form': form, - 'versionControlForm': versionControlForm + 'versionControlForm': versionControlForm, + 'entletter': entletter }) def qm(request,cave_id,qm_id,year,grade=None): |